NAME
docs/submissions.pod - Parrot Submission Instructions
ABSTRACT
How to submit bug reports, patches and new files to Parrot.
How To Submit A Bug Report
If you encounter an error while working with Parrot, and don't understand what is causing it, then submit a bug report using the parrotbug utility. The simplest way to use it is to run
% ./parrotbug
in the distribution's root directory, and follow the prompts.
However, if you do know how to fix the problem you encountered, then think about submitting a patch.
How To Submit A Patch
Try to keep your patches specific to a single change, and ensure that your change does not break any tests.
Create the patch.
In the following examples, parrot contains the Parrot distribution, and parrotdev contains parrot. The name parrotdev is just a placeholder for whatever the distribution's parent directory is called on your machine.
- Single
diff
-
If the change you wish to make is small it will generally effect only one or two files, in which case supply a
diff
for each file. Thediff
should be created in parrot.cd parrot diff -u docs/submissions.pod docs/submissions.new > submissions.patch
Win32 users will probably need
-ub
. - Recursive
diff
-
If the change is more wide-ranging, then create an identical copy of parrot in parrotdev and rename it parrot.new. Modify parrot.new and run a recursive
diff
on the two directories to create your patch. Thediff
should be created in parrotdev.cd parrotdev diff -ur --exclude='.svn' parrot parrot.new > docs.patch
OS X users should also include
--exclude=.DS_Store
. svn
-
Patches can also be generated by svn.
cd parrotdev svn diff > docs.patch
- Single
Create a plain text email.
Set the recipient to parrotbug at parrotcode dot org.
Give the message a clear and concise subject.
Prefix it with a
[PATCH]
identifier.The message body should contain an explanation of the purpose of the patch, and a list of all files affected with summary of the changes made in each file.
Attach the patch file(s).
Double-check that you've actually done this, because it's easy to forget.
DO NOT paste the patch file content into the body of the message.
Send the mail.
Applying Patches
You may wish to apply a patch submitted by someone else before the patch is incorporated into SVN.
For single diff
patches, copy the patch file to parrot, and run:
cd parrot
patch -p0 < single.patch
For recursive diff
patches, copy the patch file to parrotdev, and run:
cd parrotdev
patch -p0 < recursive.patch
Configuration of to be ignored files
Sometimes new files will be created in the configuration and build process of Parrot. These files should not show up when checking the distribution with
svn status
or
perl tools/dev/manicheck.pl
The list of these ignore files can be set up with:
svn propedit svn:ignore <PATH>
In order to keep the two different checks synchronized, the MANIFEST.SKIP file should be regenerated with:
perl tools/dev/gen_manifest_skip.pl > MANIFEST.SKIP
How To Submit Something New
If you have a new feature to add to Parrot, such as a new test.
Add your new file path(s), relative to parrot, to the file MANIFEST. Create a patch for the MANIFEST file according to the instructions above in How To Submit A Patch
If you have a new test script ending in .t, some mailers may become confused and consider it an application/x-troff. One way around this (for *nix users) is to diff the file against /dev/null like this:
cd parrot diff -u /dev/null newfile.t > newfile.patch
Create a plain text email.
Set the recipient to parrotbug at parrotcode dot org.
Give the message a clear and concise subject.
Prefix it with a
[NEW]
identifier.The message body should contain an explanation of the purpose of the feature you are adding.
Attach the patch for MANIFEST and your new file(s).
Double-check that you've actually done this, because it's easy to forget.
DO NOT paste the content of the new file or files into the body of the message.
Send the mail.
What Happens Next?
RT creates a ticket for the submission, and you will receive an automatic reply with details of the ticket identifier. This identifier should be used in all further correspondence concerning the submission.
Everyone on the list sees the submission, and can comment on it. A developer with SVN commit authority will commit it to SVN once it is clear that it is the right thing to do.
Even those developers with SVN commit authority stick to this scheme for all but the most trivial of their own patches, to allow time for peer review of their changes.
You can check the progress of your submission at the Parrot bugs page http://bugs6.perl.org/. If you have trouble logging in try username guest
with password guest
.
A Parrot Bug Summary page is also generated and can be viewed here http://rt.perl.org/rt3/NoAuth/parrot/Overview.html
A list of all the unresolved patches is at http://www.parrotcode.org/openpatches.html
HISTORY
Adapted by Michael Scott from a tutorial submitted by Aldo Calpini, with some additional remarks from Bruce Gray.